-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
Sorry. I accidentally compared with wrong branch. |
Okay, thanks for the clarification; I was confused. Are you intending to submit a pull request in the future, though? |
Hope so if you want this work to be part of the project.
|
I don't support Stack on any of my projects. You are welcome to use Stack to build it, obviously, but I will not accept any patches containing Stack package files.
This breaks existing installations. Does your patch deal with compatibility?
Can you be more specific?
Can you be more specific here, too? Do you mean Travis? And as for efficiency, details would be helpful there, too. Thanks! |
Is this patch acceptable at all?
Sorry. As I see there is no dependencies changed against master. Of course commit messages will be more adequate in real PR.
I mean Travis or Circle. About efficiency: I forked the project first to learn hasql on practice. Following database mapping engine change I went through the code and replaced I didn't expect it to be part of origin ever but I'm ready to work on it in sense of this discussion. |
I would be happy to accept a patch that worked for either extension. So, to be specific, when the tool creates new migrations it can create them with a Also, the patch for this should also document the behavior in the relevant places, especially
I prefer Travis, so I'd be happy to accept a patch that sets that up. As far as performance goes, Thanks! |
This branch is intended to be stable version of this fork.
There is no
hasql
since it does not support GHC-8.4.Also there is working test suite.
TODO: